Question about OpenSfm code

oradzhabov · 15 January 2022 08:13

Hi.

Starting from tag 268 I see not matching interfaces between calling method

OpenDroneMap/OpenSfM/blob/c90b0344a725c6048883e390b771da46999400fc/opensfm/commands/undistort.py#L11


      
          from opensfm.actions import undistort
          
          
from . import command
          
          

          
class Command(command.CommandBase):
              name = "undistort"
              help = "Save radially undistorted images"
          
          
    def run_impl(self, dataset, args):
                  undistort.run_dataset(
                      dataset,
                      args.reconstruction,
                      args.reconstruction_index,
                      args.tracks,
                      args.output,
                      args.skip_images
                  )
          
          
    def add_arguments_impl(self, parser):
                  parser.add_argument(

and implementation

github.com

OpenDroneMap/OpenSfM/blob/c90b0344a725c6048883e390b771da46999400fc/opensfm/actions/undistort.py#L15


      
          from opensfm.dataset import DataSet
          from typing import Callable
          import numpy as np
          
          
def run_dataset(
              data: DataSet,
              reconstruction: Optional[str] = None,
              reconstruction_index: int = 0,
              tracks: Optional[str] = None,
              output: str = "undistorted",
              imageFilter: Callable[[str, np.ndarray], np.ndarray] = None,
              skip_images: bool = False,
          ) -> None:
              """Export reconstruction to NVM_V3 format from VisualSfM
          
          
    Args:
                  reconstruction: reconstruction to undistort
                  reconstruction_index: index of the reconstruction component to undistort
                  tracks: tracks graph of the reconstruction
                  output: undistorted
                  skip_images: do not undistort images

Parameter imageFilter became False and then raise exception in function
def undistort_image_and_masks(arguments) → None:

Saijin_Naib · 15 January 2022 14:45

Welcome!

Thanks for spotting that.

Have you tested a fix? Does it improve things and stop the error?

pierotofy · 15 January 2022 16:53

That’s because we don’t call opensfm undistort. Instead we call it from ODM/osfm.py at 09cb979aae755e2adfa0c4afdffc45d895a5df3a · OpenDroneMap/ODM · GitHub