Non ascii character in ODM Install Path

bernarde · 21 March 2022 11:58

Hi,

I have open the following bug :

Non ascii character in ODM Install Path

opened 11:46AM - 21 Mar 22 UTC

### How did you install OpenDroneMap? (Docker, natively, ...)? Natively on Wi…ndows 10 ### What is the problem? ODM Console not functionnal if there is a non ascii character in ODM Install Path, for instance Cyrillic characters. ### What should be the expected behavior? If this is a feature request, please describe in detail the changes you think should be made to the code, citing files and lines where changes should be made, if possible. Console should function ### How can we reproduce this? (What steps did you do to trigger the problem? What parameters are you using for processing? If possible please include a copy of your dataset uploaded on Google Drive or Dropbox. Be detailed) Insert a non ascii character in ODM Install Path, for instance a Cyrillic character. Here is the error log : ```['C:\\space é folder\\ODM', 'C:\\space Ã© folder\\ODM\\venv\\lib\\site-packages\\cv2\\python-3.8', 'C:\\space é folder\\ODM\\venv', 'C:\\space é folder\\ODM\\python38\\python38.zip', 'C:\\space é folder\\ODM\\python38\\DLLs', 'C:\\space é folder\\ODM\\python38\\lib', 'C:\\space é folder\\ODM\\python38', 'C:\\space é folder\\ODM\\venv\\lib\\site-packages', 'C:\\space é folder\\ODM\\SuperBuild\\install/lib/python3.9/dist-packages', 'C:\\space é folder\\ODM\\SuperBuild\\install/lib/python3.8/dist-packages', 'C:\\space é folder\\ODM\\SuperBuild\\install/lib/python3/dist-packages', 'C:\\space é folder\\ODM\\SuperBuild\\install/bin/opensfm'] Traceback (most recent call last): File "C:\space é folder\ODM\\run.py", line 15, in <module> from opendm.utils import get_processing_results_paths, rm_r File "C:\space é folder\ODM\opendm\utils.py", line 3, in <module> from opendm.photo import find_largest_photo_dim File "C:\space é folder\ODM\opendm\photo.py", line 16, in <module> from opendm import get_image_size File "C:\space é folder\ODM\opendm\get_image_size.py", line 2, in <module> import cv2 File "C:\space é folder\ODM\venv\lib\site-packages\cv2\__init__.py", line 99, in <module> bootstrap() File "C:\space é folder\ODM\venv\lib\site-packages\cv2\__init__.py", line 88, in bootstrap import cv2 File "C:\space é folder\ODM\venv\lib\site-packages\cv2\__init__.py", line 99, in <module> bootstrap() File "C:\space é folder\ODM\venv\lib\site-packages\cv2\__init__.py", line 23, in bootstrap raise ImportError('ERROR: recursion is detected during loading of "cv2" binary extensions. Check OpenCV installation.') ImportError: ERROR: recursion is detected during loading of "cv2" binary extensions. Check OpenCV installation.```

The fact is we have some systems which use chinese or cyrillic characters and ODM can not run on those currently.

I am not an expert in python but trying to understand I found the following:

It comes from an encoding issue
The faulty line is this one:
with open(fpath) as f: line 7 in venv\Lib\site-packages\cv2\load_config_py3.py
I found two ways or fixing the issue:
- Change the previous line to force utf8 encoding which should be default behaviour in python, I guess (PEP 540 – Add a new UTF-8 Mode | peps.python.org) : with open(fpath,encoding='utf8') as f: but this is uggly and I do not know who is responsible for this file in venv. I absolutely do not understand package and virtual environments in python sorry. Not sure if we can contact them or have sufficient weight to leverage this.
- Force globally python to use utf8 in ODM, adding in winrun.bat the -X utf8 flag. Hence becoming python -X utf8 "%ODMBASE%\run.py" %* instead of python "%ODMBASE%\run.py" %*

What do you think ? Is there any other fix or solution I am missing that we can act uppon ?

Saijin_Naib · 21 March 2022 13:28

Thanks for surfacing this, bernarde, and for providing an example in your GitHub issue…

I thought modern Python runtimes should use OS file handling routines that can manage non-ASCII characters, but I was apparently wrong.

I don’t know which approach is right, unfortunately, but it definitely is an important thing to address.

bernarde · 23 March 2022 10:14

After further testing it appears that non ascci charaters in projet path are causing other errors later.

Good news is that the second fix I suggest allow to patch this also. I have open a PR for this. Up to the community to give its appreciation of the situation :

Saijin_Naib · 23 March 2022 12:54

Wonderful! Thanks so much for you assistance and hard work helping us fix this!

system · 22 April 2022 12:55

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.