Dev questions

Developers Chat
1

Hi,
I have some questions on Linux:

  • In the ODM README, after launching ./start-dev-env.sh, the first command to start is
(odmdev) [user:/code] master+* ± bash configure.sh reinstall

Why not install instead of reinstall ?

  • If I exit the dev terminal and I want to restart it with ./start-dev-env.sh, I have the error that the container name already exist. What can I do ?

Is it possible to use ./start-dev-env.sh with Macos ?

Thanks

1 Like
2

Because that will make sure to nuke the “SuperBuild” directory, which needs to be rebuilt (if it exists already).

docker start odmdev
docker exec -ti odmdev bash
su <youruser>

With some adjustments, probably (help us improve the script?)

3 Likes
3

The first thing I see that’s potentially a problem: the tooling appears to expect X11 to be set up on the host computer (the one running Docker) and I haven’t looked into how much fun that would be to set up on a Mac. :frowning:

1 Like
4

Update: XQuartz is a thing, and it’s running on my MacBook Pro so there’s that.

I just commented out the exit 1 in the Linux check to see what happened. It took forever, but I got the following message:

###################################
ODM Dev Environment Ready. Hack on!
###################################

I cannot vouch for its completeness or correctness, mind you, but at least it got this far!

2 Likes
5

Further than I’ve ever managed and I’m on Linux with X11, so you’re doing great :rofl:

1 Like
6

I ran the bash command to rebuild everything, then tried the run command and it’s currently building a dataset. I have no idea why it wants X11, maybe for folks who want to run an GUI editor from within the container, that’s a question for the active contributors. :slight_smile: If that’s all, make that bit optional and Mac folks can start the dev environment!

1 Like
7

That’s only so that this allows GUIs like Qt Creator to work; but it’s not required (you can just skip mounting the X11 volumes on Mac).

1 Like
8

If my work allowed me to make arbitrary pull requests, I’d make one that did the following:

  • removed the Linux check
  • checked for xhost as is done for docker
  • added the X11 volumes to the docker command line if the above check passed, and
  • only called it if the above check passed

If a Windows person tries to use it and complains, encourage them to write the code to make it work for Windows. :slight_smile:

2 Likes
9

Ah, well, those policies are unfortunate.

Make sure your employer is aware of their licensing responsibilities too! ODM/LICENSE at master · OpenDroneMap/ODM · GitHub

2 Likes
10

Alas, my company has a team of lawyers and software folks (hopefully more of the latter than the former) that would keep us from using AGPL-licensed software in the general case. If the rules change, you’ll be among the first to know. :slight_smile:

1 Like
11

Always a challenge, and I have been surprised by how often lawyers get GPL and AGPL wrong: I have gently corrected very expensive IP lawyers on calls regarding obligations under licenses.

(FYI, I am not a lawyer…)

For a good review of the myths around AGPL, check out this: The falsehoods of anti-AGPL propaganda

And share with your lawyers! Hopefully they are as patient as the ones I have encountered. :smiley:

ht: Piero for sharing that article or some iteration of it with me.

3 Likes