Deprecated options

zarg404 · 30 March 2023 12:56

Hi,
As I am working on inproving my workflow, I noticed that some options are deprecated.

OpenDroneMap/ODM/blob/4b3306ec9e1bd9d4b58771ec9b58eeec343b4726/opendm/config.py#L788


      
          
          
parser.add_argument('--skip-band-alignment',
                          action=StoreTrue,
                          nargs=0,
                          default=False,
                          help=('When processing multispectral datasets, ODM will automatically align the images for each band. '
                                'If the images have been postprocessed and are already aligned, use this option. '
                                'Default: %(default)s'))
          
          
args, unknown = parser.parse_known_args(argv)
          DEPRECATED = ["--verbose", "--debug", "--time", "--resize-to", "--depthmap-resolution", "--pc-geometric", "--texturing-data-term", "--texturing-outlier-removal-type", "--texturing-tone-mapping"]
          unknown_e = [p for p in unknown if p not in DEPRECATED]
          if len(unknown_e) > 0:
              raise parser.error("unrecognized arguments: %s" % " ".join(unknown_e))
          
          
for p in unknown:
              if p in DEPRECATED:
                  log.ODM_WARNING("%s is no longer a valid argument and will be ignored!" % p)
          
          
# check that the project path setting has been set properly
          if not args.project_path:

Maybe they need to be removed from the documentation or flagged as deprecated ?
What do you prefer ? I can do it !

By the way pc-geometric although deprecated is used in WebODM ‘Buildings’ profile

github.com

sushidub/WebODM/blob/3d7841fab74a96baa9611cdf0413c819f7eb7007/app/boot.py#L121


      
                                                                {'name': 'use-3dmesh', 'value': True},]})
          Preset.objects.update_or_create(name='3D Model', system=True,
                                          defaults={'options': [{'name': 'auto-boundary', 'value': True},
                                                                {'name': 'mesh-octree-depth', 'value': "12"},
                                                                {'name': 'use-3dmesh', 'value': True},
                                                                {'name': 'pc-quality', 'value': 'high'},
                                                                {'name': 'mesh-size', 'value': '300000'}]})
          Preset.objects.update_or_create(name='Buildings', system=True,
                                          defaults={'options': [{'name': 'auto-boundary', 'value': True},
                                                                {'name': 'mesh-size', 'value': '300000'},
                                                                {'name': 'pc-geometric', 'value': True},
                                                                {'name': 'pc-quality', 'value': 'high'}]})
          Preset.objects.update_or_create(name='Point of Interest', system=True,
                                          defaults={'options': [{'name': 'auto-boundary', 'value': True},
                                                                {'name': 'mesh-size', 'value': '300000'},
                                                                {'name': 'use-3dmesh', 'value': True}]})
          Preset.objects.update_or_create(name='Forest', system=True,
                                          defaults={'options': [{'name': 'auto-boundary', 'value': True},
                                                                {'name': 'min-num-features', 'value': '18000'},
                                                                {'name': 'use-3dmesh', 'value': True},
                                                                {'name': 'feature-quality', 'value': 'ultra'}]})

Saijin_Naib · 30 March 2023 19:29

I am trying to figure out tagging for Sphynx Documentation. Have any experience with this?

We hide some flags from the UI, but that doesn’t mean we don’t still use them, for example, pc-skip-geometric exists, and likely makes the most sense to reference to pc-geometric documentation to know what you are skipping.

I think so, currently at least